[
https://issues.apache.org/jira/browse/HCATALOG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265903#comment-13265903
]
[email protected] commented on HCATALOG-68:
-------------------------------------------------------
bq. On 2012-05-01 16:19:03, Francis Liu wrote:
bq. > /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java, line 172
bq. >
<https://reviews.apache.org/r/4732/diff/11/?file=105511#file105511line172>
bq. >
bq. > I'd prefer the exception be passed to the logger instead of the
exception message being printed.
Hey, but while changing please make sure the json text which is causing the
exception is also logged.
- Vandana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4732/#review7422
-----------------------------------------------------------
On 2012-04-30 20:51:07, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4732/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-30 20:51:07)
bq.
bq.
bq. Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We need to do the following things:
bq.
bq. + Use log4j across the board
bq. + Introduce a class with methods to help logging, refactoring away the
bunch of these functions in HCatUtil right now
bq. + Instrument debug logging with isLogEnabled checks on the log level
bq. + remove all instances of commented code whose purpose was for debug logs
bq.
bq.
bq. This addresses bug hcatalog-68.
bq. https://issues.apache.org/jira/browse/hcatalog-68
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/ivy.xml 1332376
bq. /trunk/src/java/org/apache/hcatalog/cli/HCatCli.java 1332376
bq.
/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
1332376
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1332376
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1332376
bq.
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1332376
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1332376
bq. /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1332376
bq.
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1332376
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1332376
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1332376
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1332376
bq. /trunk/src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java
1332376
bq. /trunk/src/test/org/apache/hcatalog/cli/TestPermsGrp.java 1332376
bq. /trunk/src/test/org/apache/hcatalog/cli/TestSemanticAnalysis.java
1332376
bq. /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1332376
bq. /trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java
1332376
bq. /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1332376
bq. /trunk/src/test/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java
1332376
bq. /trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java
1332376
bq.
/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
1332376
bq. /trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java
1332376
bq. /trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java
1332376
bq.
/trunk/src/test/org/apache/hcatalog/rcfile/TestRCFileMapReduceInputFormat.java
1332376
bq.
bq. Diff: https://reviews.apache.org/r/4732/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass. Log messages verified from test logs.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> Logging from HCat
> -----------------
>
> Key: HCATALOG-68
> URL: https://issues.apache.org/jira/browse/HCATALOG-68
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Sushanth Sowmyan
> Assignee: Vandana Ayyalasomayajula
>
> We need to do the following things:
> + Use log4j across the board
> + Introduce a class with methods to help logging, refactoring away the
> bunch of these functions in HCatUtil right now
> + Instrument debug logging with isLogEnabled checks on the log level
> + remove all instances of commented code whose purpose was for debug logs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
