[ 
https://issues.apache.org/jira/browse/HDFS-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538654#comment-14538654
 ] 

Tsz Wo Nicholas Sze commented on HDFS-8143:
-------------------------------------------

- Rename the new conf "dfs.mover.failed.retry" to 
"dfs.mover.retry.max.attempts".
- The conf should be read in the Mover constructor.
{code}
+    private static int moverFailedRetry; //For keeping configured value
+    private static int moverFailedRetryCounter; //For calculation
{code}
- The above two fields should be moved to the Mover class instead of the Cli 
class.  Both of them should be non-static and moverFailedRetry should be final.
- Rename moverFailedRetry to retryMaxAttempts and moverFailedRetryCounter to 
retryCount


> HDFS Mover tool should exit after some retry when failed to move blocks.
> ------------------------------------------------------------------------
>
>                 Key: HDFS-8143
>                 URL: https://issues.apache.org/jira/browse/HDFS-8143
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer & mover
>    Affects Versions: 2.6.0
>            Reporter: surendra singh lilhore
>            Assignee: surendra singh lilhore
>            Priority: Blocker
>         Attachments: HDFS-8143.patch, HDFS-8143_1.patch
>
>
> Mover is not coming out in case of failed to move blocks.
> {code}
> hasRemaining |= Dispatcher.waitForMoveCompletion(storages.targets.values());
> {code}
> {{Dispatcher.waitForMoveCompletion()}} will always return true if some blocks 
> migration failed. So hasRemaining never become false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to