[
https://issues.apache.org/jira/browse/HDFS-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540469#comment-14540469
]
Tsz Wo Nicholas Sze commented on HDFS-8143:
-------------------------------------------
{code}
+ retryCount = new AtomicInteger(0);
{code}
The above should be replaced by retryCount.set(0). Otherwise, there is a
object created each time. Also, retryCount should also be final. Patch looks
good other than that.
> HDFS Mover tool should exit after some retry when failed to move blocks.
> ------------------------------------------------------------------------
>
> Key: HDFS-8143
> URL: https://issues.apache.org/jira/browse/HDFS-8143
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Affects Versions: 2.6.0
> Reporter: surendra singh lilhore
> Assignee: surendra singh lilhore
> Priority: Blocker
> Attachments: HDFS-8143.patch, HDFS-8143_1.patch, HDFS-8143_2.patch
>
>
> Mover is not coming out in case of failed to move blocks.
> {code}
> hasRemaining |= Dispatcher.waitForMoveCompletion(storages.targets.values());
> {code}
> {{Dispatcher.waitForMoveCompletion()}} will always return true if some blocks
> migration failed. So hasRemaining never become false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
