[
https://issues.apache.org/jira/browse/HDFS-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539209#comment-14539209
]
Tsz Wo Nicholas Sze commented on HDFS-8143:
-------------------------------------------
I see. But putting them as static in Cli seems wrong. Let's do the following:
- Put retryMaxAttempts as non-static final in Mover.
- Add retryCount as an AtomicInteger, a local variable in Mover.run(..). Pass
it via the Mover constructor.
> HDFS Mover tool should exit after some retry when failed to move blocks.
> ------------------------------------------------------------------------
>
> Key: HDFS-8143
> URL: https://issues.apache.org/jira/browse/HDFS-8143
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Affects Versions: 2.6.0
> Reporter: surendra singh lilhore
> Assignee: surendra singh lilhore
> Priority: Blocker
> Attachments: HDFS-8143.patch, HDFS-8143_1.patch
>
>
> Mover is not coming out in case of failed to move blocks.
> {code}
> hasRemaining |= Dispatcher.waitForMoveCompletion(storages.targets.values());
> {code}
> {{Dispatcher.waitForMoveCompletion()}} will always return true if some blocks
> migration failed. So hasRemaining never become false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
