[jira] [Commented] (HDFS-8143) HDFS Mover tool should exit after some retry when failed to move blocks.

[surendra singh lilhore (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539168#comment-14539168
 ] 

surendra singh lilhore commented on HDFS-8143:
----------------------------------------------

Thanks [~szetszwo] for comments 

bq. The above two fields should be moved to the Mover class instead of the Cli 
class. Both of them should be non-static and moverFailedRetry should be final.

I declared both the fields static in Cli purposefully. For each iteration we 
will create one new mover object, so for retry counter mover object fields are 
not useful.
Please give your suggestion, do I need to change??
{code}
      while (iter.hasNext()) {
          NameNodeConnector nnc = iter.next();
          final Mover m = new Mover(nnc, conf);
          final ExitStatus r = m.run();
          .....................
          .....................
      }
{code}

> HDFS Mover tool should exit after some retry when failed to move blocks.
> ------------------------------------------------------------------------
>
>                 Key: HDFS-8143
>                 URL: https://issues.apache.org/jira/browse/HDFS-8143
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer & mover
>    Affects Versions: 2.6.0
>            Reporter: surendra singh lilhore
>            Assignee: surendra singh lilhore
>            Priority: Blocker
>         Attachments: HDFS-8143.patch, HDFS-8143_1.patch
>
>
> Mover is not coming out in case of failed to move blocks.
> {code}
> hasRemaining |= Dispatcher.waitForMoveCompletion(storages.targets.values());
> {code}
> {{Dispatcher.waitForMoveCompletion()}} will always return true if some blocks 
> migration failed. So hasRemaining never become false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)