[ 
https://issues.apache.org/jira/browse/HDFS-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988984#comment-14988984
 ] 

J.Andreina commented on HDFS-9364:
----------------------------------

[~xiaochen] ,thanks for raising this issue.Patch looks good to me.
I have few review comments.

1.
  Following place also requires a check on whether NNURI is logical or not.
        {{DFSUtilClient#getNNAddress(Configuration conf)}}  --> should 
internally call {{DFSUtilClient#getNNAddressCheckLogical()}}

2.
As the check on NNURI is logical, is not necessary for Non-HA cluster,in patch 
checks at following places is not required
        {{NameNodeProxies#createProxy}}
        {{NameNodeProxiesClient#createProxyWithClientProtocol}}

> Unnecessary DNS resolution attempts when creating NameNodeProxies
> -----------------------------------------------------------------
>
>                 Key: HDFS-9364
>                 URL: https://issues.apache.org/jira/browse/HDFS-9364
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HDFS-9364.001.patch
>
>
> When creating NameNodeProxies, we always try to DNS-resolve namenode URIs. 
> This is unnecessary if the URI is logical, and may be significantly slow if 
> the DNS is having problems. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to