[
https://issues.apache.org/jira/browse/HDFS-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990800#comment-14990800
]
Zhe Zhang commented on HDFS-9364:
---------------------------------
Thanks Xiao for the patch and [~andreina] for the review.
Should we add the {{isLogicalUri}} logic to the existing {{getNNAddress(URI
filesystemURI)}} method? Is there a downside of always doing this check? It's
cleaner to have one util method to handle all cases, assuming the check doesn't
harm non-HA cases.
Another minor point in the 03 patch is that {{DFSUtilClient.}} is redundant:
{code}
retAddr = DFSUtilClient.getNNAddress(filesystemURI);
{code}
> Unnecessary DNS resolution attempts when creating NameNodeProxies
> -----------------------------------------------------------------
>
> Key: HDFS-9364
> URL: https://issues.apache.org/jira/browse/HDFS-9364
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-9364.001.patch, HDFS-9364.002.patch,
> HDFS-9364.003.patch
>
>
> When creating NameNodeProxies, we always try to DNS-resolve namenode URIs.
> This is unnecessary if the URI is logical, and may be significantly slow if
> the DNS is having problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
