[ 
https://issues.apache.org/jira/browse/HDFS-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989117#comment-14989117
 ] 

J.Andreina commented on HDFS-9364:
----------------------------------

bq. I think it's theoretically possible for a misconfigured cluster to reach 
there and silently try to resolve in said methods....Another option is to do a 
precondition check here instead of handling it, but I feel that may be too 
aggressive... What do you think?

[~xiaochen], As u have mentioned, there is already a check for 
failoverProxyProvider as below
{code}
    if (failoverProxyProvider == null) {
      return createNonHAProxy(conf, DFSUtilClient.getNNAddress(nameNodeUri),
          xface, UserGroupInformation.getCurrentUser(), true,
          fallbackToSimpleAuth);
    }
{code}
Here for any Non-HA cluster/for HA cluster where NameNode URI is configured to 
an ip:port(illogical URI), there is no necessity for configuring 
failoverProxyProvider(hence failoverProxyProvider would be null )

So i feel, here it is not required to handle cases with misconfigurations :).

> Unnecessary DNS resolution attempts when creating NameNodeProxies
> -----------------------------------------------------------------
>
>                 Key: HDFS-9364
>                 URL: https://issues.apache.org/jira/browse/HDFS-9364
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HDFS-9364.001.patch, HDFS-9364.002.patch
>
>
> When creating NameNodeProxies, we always try to DNS-resolve namenode URIs. 
> This is unnecessary if the URI is logical, and may be significantly slow if 
> the DNS is having problems. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to