[
https://issues.apache.org/jira/browse/HDFS-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991939#comment-14991939
]
Xiao Chen commented on HDFS-9364:
---------------------------------
Thanks [~zhz] for the review!
bq. Is there a downside of always doing this check?
I didn't add {{isLogicalUri}} because it requires both the {{Configuration}}
and the {{URI}}. The method {{getNNAddress(URI)}} doesn't have
{{Configuration}} currently, and is declared *public*. So adding conf would
make it backwards incompatible. I investigated in our code base, all places
invoking {{getNNAddress(URI)}} we can get the conf. But we can't assume no
client code is using it. Do you think mark {{getNNAddress(URI)}} as deprecated
and add {{getNNAddress(Configuration, URI)}} is the way to go?
bq. Another minor point in the 03 patch is that DFSUtilClient. is redundant.
Good catch. I'll fix it after receiving the above feedback. :)
> Unnecessary DNS resolution attempts when creating NameNodeProxies
> -----------------------------------------------------------------
>
> Key: HDFS-9364
> URL: https://issues.apache.org/jira/browse/HDFS-9364
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-9364.001.patch, HDFS-9364.002.patch,
> HDFS-9364.003.patch
>
>
> When creating NameNodeProxies, we always try to DNS-resolve namenode URIs.
> This is unnecessary if the URI is logical, and may be significantly slow if
> the DNS is having problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
