[ 
https://issues.apache.org/jira/browse/HDFS-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173336#comment-15173336
 ] 

Akira AJISAKA commented on HDFS-8356:
-------------------------------------

Reviewed the part before "dfs.client.retry.interval-ms.get-last-block-length".

# In "dfs.client.failover.proxy.provider", "required hostname" should be 
"nameservice ID". I'm thinking the description should link to HDFS-HA document. 
The parameter is well-documented there.
# Would you add a description of "dfs.client.read.prefetch.size"? Now it shows 
only the default value.
# In "dfs.client.read.short.curcuit.replica.stale.threshold.ms" and 
"dfs.client.read.shortcircuit.buffer.size", "local read short circuit" should 
be "short-circuit local reads".
# Would you add a detailed comment for 
"dfs.client.replica.accessor.builder.classes", such as "Comma-separated classes 
for building ReplicaAccessor. If the classes are specified, client will use 
external BlockReader that uses the ReplicaAccessor built by the builder."?


> Document missing properties in hdfs-default.xml
> -----------------------------------------------
>
>                 Key: HDFS-8356
>                 URL: https://issues.apache.org/jira/browse/HDFS-8356
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: supportability, test
>         Attachments: HDFS-8356.001.patch, HDFS-8356.002.patch, 
> HDFS-8356.003.patch, HDFS-8356.004.patch, HDFS-8356.005.patch
>
>
> The following properties are currently not defined in hdfs-default.xml. These 
> properties should either be
> A) documented in hdfs-default.xml OR
> B) listed as an exception (with comments, e.g. for internal use) in the 
> TestHdfsConfigFields unit test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to