[ 
https://issues.apache.org/jira/browse/HDFS-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187092#comment-15187092
 ] 

Akira AJISAKA commented on HDFS-8356:
-------------------------------------

Reviewed to "dfs.ha.fencing.methods".
# "dfs.datanode.min.supported.namenode.version" and "dfs.datanode.startup" are 
not supposed to be configured by users, so we can remove them from 
hdfs-default.xml.
# In "dfs.datanode.oob.timeout-ms", we should document that OOB types are 
OOB_RESTART, OOB_RESERVED1, OOB_RESERVED2, and OOB_RESERVED3, and now only 
OOB_RESTART is used.
# In "dfs.datanode.parallel.volumes.load.threads.num", would you document that 
the default value is the number of storages in the DataNode?
# In "dfs.datanode.socket.write.timeout", we should document that the parameter 
is valid for DataNodes, not for DFSClient.
# Would you document that "dfs.datanode.sync.behind.writes.in.background" is 
valid only when "dfs.datanode.sync.behind.writes" is set to true?
# In "dfs.datanode.transferTo.allowed", I'm thinking "If true" should be "If 
false".
# Would you remove unnecessarily whitespace in "m achine" in the description of 
"dfs.datanode.transferTo.allowed"?
# In "dfs.ha.fencing.methods", we can document that 
the parameter is well-documented in HDFS-HA doc, as well as 
"dfs.client.failover.proxy.provider".


> Document missing properties in hdfs-default.xml
> -----------------------------------------------
>
>                 Key: HDFS-8356
>                 URL: https://issues.apache.org/jira/browse/HDFS-8356
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: supportability, test
>         Attachments: HDFS-8356.001.patch, HDFS-8356.002.patch, 
> HDFS-8356.003.patch, HDFS-8356.004.patch, HDFS-8356.005.patch, 
> HDFS-8356.006.patch
>
>
> The following properties are currently not defined in hdfs-default.xml. These 
> properties should either be
> A) documented in hdfs-default.xml OR
> B) listed as an exception (with comments, e.g. for internal use) in the 
> TestHdfsConfigFields unit test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to