[ 
https://issues.apache.org/jira/browse/HDFS-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186941#comment-15186941
 ] 

Akira AJISAKA commented on HDFS-8356:
-------------------------------------

Thank you [~rchiang] for the update! Reviewed to 
"dfs.datanode.min.supported.namenode.version".
# Duplicate "during" in the description of "dfs.client.read.prefetch.size".
# In "dfs.client.read.short.curcuit.replica.stale.threshold.ms", "local read 
short circuit" should be "short-circuit local reads".
# Would you make the order of "name", "value", "description" consistent?
# In "dfs.data.transfer.client.tcpnodelay", the parameter affects only when 
creating sockets for write pipeline, so it's better to write as "If true, set 
TCP_NODELAY to sockets for transferring data from DFS client."
# Would you document that "dfs.datanode.balance.max.concurrent.moves" is 
reconfigurable via dfsadmin -reconfig command?
# "dfs.datanode.duplicate.replica.deletion" is for testing only, so would you 
remove it from hdfs-default.xml?
# In "dfs.datanode.fsdataset.volume.choosing.policy", would you mention that 
"If you would like to take into account available disk space, set the value to 
"org.apache.hadoop.hdfs.server.datanode.fsdataset.AvailableSpaceVolumeChoosingPolicy"."?
# Would you remove "dfs.datanode.kerberos.principal" and 
"dfs.datanode.keytab.file", which are already documented?


> Document missing properties in hdfs-default.xml
> -----------------------------------------------
>
>                 Key: HDFS-8356
>                 URL: https://issues.apache.org/jira/browse/HDFS-8356
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: supportability, test
>         Attachments: HDFS-8356.001.patch, HDFS-8356.002.patch, 
> HDFS-8356.003.patch, HDFS-8356.004.patch, HDFS-8356.005.patch, 
> HDFS-8356.006.patch
>
>
> The following properties are currently not defined in hdfs-default.xml. These 
> properties should either be
> A) documented in hdfs-default.xml OR
> B) listed as an exception (with comments, e.g. for internal use) in the 
> TestHdfsConfigFields unit test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to