[
https://issues.apache.org/jira/browse/HDFS-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030758#comment-16030758
]
Yuanbo Liu commented on HDFS-11779:
-----------------------------------
[~cheersyang]Thanks for v8 patch, here are my comments:
1. LevelDBKeyFilter.java.
There is a class file called {{FilteredKeys.java}} in ozone project, can we
leverage this part of work and combine them together
so that we can get rid of some overlap code.
2. LevelDBStore.java
a.
{code}
result.add(new AbstractMap.SimpleEntry(
current.getKey(), current.getValue()));
{code}
we can add the entry directly here like this, there seems no need to copy-add
because we read the value from DB(Native code)
{code}
result.add(current)
{code}
b.
{code}
DBIterator dbIter = getIterator();
{code}
Since DBIterator is a closeable class, we can use {{try}} to wrap this code
sentence for safely closing {{dbIter}}
{code}
try(DBIterator dbIter = getIterator()) {
...
}
{code}
> Ozone: KSM: add listBuckets
> ---------------------------
>
> Key: HDFS-11779
> URL: https://issues.apache.org/jira/browse/HDFS-11779
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Weiwei Yang
> Attachments: HDFS-11779-HDFS-7240.001.patch,
> HDFS-11779-HDFS-7240.002.patch, HDFS-11779-HDFS-7240.003.patch,
> HDFS-11779-HDFS-7240.004.patch, HDFS-11779-HDFS-7240.005.patch,
> HDFS-11779-HDFS-7240.006.patch, HDFS-11779-HDFS-7240.007.patch,
> HDFS-11779-HDFS-7240.008.patch
>
>
> Lists buckets of a given volume. Similar to listVolumes, paging supported via
> prevKey, prefix and maxKeys.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
