[
https://issues.apache.org/jira/browse/HDFS-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027157#comment-16027157
]
Anu Engineer commented on HDFS-11779:
-------------------------------------
bq. javax.annotation because I found many other places in HDFS project used
this annotation and this helps to read the function signature so I added them.
If you insist I can remove this in next patch.
I am personally conflicted with this. I know it is a great annotation to have
and Java 8 has support for checkers. Unfortunately most of these annotations
live in some checker packages -- take a look at FindBugs Documentation on
checkers. That said, I am fine with this change if you think it is ok to use.
It is just that javax is the cross-platform UI package. If we ever decide to
create layers like java 9 -- these will come back to haunt us. So right now I
leave it to your judgement.
bq. maxNumOfBuckets, because it allows a value <0, which means no limit at all.
While it is a good idea to have no limit support from user perspective, it has
the potential for abuse. So I think we must not only check for the negative
value, but also define a max entries in a listing operation( like [~xyao] is
suggesting -- may be a max value of 1024) . Since we support paging, I don't
see why a user will want to read arbitrarily large listing from ozone. I am not
able to convince myself that we should give such an option to user.
bq. I intent to raise another JIRA to improve this.
Perfect, that is my intention as well
> Ozone: KSM: add listBuckets
> ---------------------------
>
> Key: HDFS-11779
> URL: https://issues.apache.org/jira/browse/HDFS-11779
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Weiwei Yang
> Attachments: HDFS-11779-HDFS-7240.001.patch,
> HDFS-11779-HDFS-7240.002.patch, HDFS-11779-HDFS-7240.003.patch,
> HDFS-11779-HDFS-7240.004.patch, HDFS-11779-HDFS-7240.005.patch,
> HDFS-11779-HDFS-7240.006.patch
>
>
> Lists buckets of a given volume. Similar to listVolumes, paging supported via
> prevKey, prefix and maxKeys.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
