[
https://issues.apache.org/jira/browse/HDFS-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026980#comment-16026980
]
Xiaoyu Yao commented on HDFS-11779:
-----------------------------------
Thanks [~cheersyang] for the patch. The v6 patch looks excellent to me. Just
have few minor issues in addition to [~anu]'s comments above.
DistributedStorageHandler.java
Line 272: To avoid overflow, we might consider enforce paging by having a
default MaxKeys per list request (say 100) if the MaxKeys is not specified in
the request. If the caller really want to listAll, they can specify the MaxKeys
with a negative value (like -1).
Line 280-287: this can be simplified with
{code} bucketsInfo.add(bucketInfo.getProtobuf()); {code}
> Ozone: KSM: add listBuckets
> ---------------------------
>
> Key: HDFS-11779
> URL: https://issues.apache.org/jira/browse/HDFS-11779
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Weiwei Yang
> Attachments: HDFS-11779-HDFS-7240.001.patch,
> HDFS-11779-HDFS-7240.002.patch, HDFS-11779-HDFS-7240.003.patch,
> HDFS-11779-HDFS-7240.004.patch, HDFS-11779-HDFS-7240.005.patch,
> HDFS-11779-HDFS-7240.006.patch
>
>
> Lists buckets of a given volume. Similar to listVolumes, paging supported via
> prevKey, prefix and maxKeys.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
