[
https://issues.apache.org/jira/browse/HDFS-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027152#comment-16027152
]
Weiwei Yang commented on HDFS-11779:
------------------------------------
Hello [~anu] and [~xyao]
Thanks for your comments, I will submit a new patch today to address them. Few
things though
bq. Nullable and Nonnull annotations
I used {{javax.annotation}} because I found many other places in HDFS project
used this annotation and this helps to read the function signature so I added
them. If you insist I can remove this in next patch. Thanks.
bq. BucketManagerImpl.java: Check if this value is greater than 0 ?
maxNumOfBuckets
This is the server side impl class, I don't think we need to check the value of
{{maxNumOfBuckets}}, because it allows a value <0, which means no limit at all.
bq. Just a meta-comment – getVolumeBucket I don't want to change this code in
this patch, but I would like to formalize all these parsing assumptions in one
single class – so this info is localized in one file.
I intent to raise another JIRA to improve this. Right now the key in KSM might
be in multiple schemas, 1) volume key - "/volume_name"; 2) bucket key -
"/volume_name/bucket_name"; 3) user key - "$user_name". I would like to create
a protobuf message to encapsulate this, so we can leverage protobuf to parse
and get byte arrays then persist them into KSM DB. If you agree, I will work on
this on another JIRA.
bq. Line 280-287: this can be simplified with
bucketsInfo.add(bucketInfo.getProtobuf());
The problem is the BucketInfo in {{ListBuckets}} is
{{org.apache.hadoop.ozone.web.response.BucketInfo}}, but
bucketInfo.getProtobuf() returns {{KeySpaceManagerProtocolProtos.BucketInfo}}.
So same name but different package.
Thanks
> Ozone: KSM: add listBuckets
> ---------------------------
>
> Key: HDFS-11779
> URL: https://issues.apache.org/jira/browse/HDFS-11779
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Weiwei Yang
> Attachments: HDFS-11779-HDFS-7240.001.patch,
> HDFS-11779-HDFS-7240.002.patch, HDFS-11779-HDFS-7240.003.patch,
> HDFS-11779-HDFS-7240.004.patch, HDFS-11779-HDFS-7240.005.patch,
> HDFS-11779-HDFS-7240.006.patch
>
>
> Lists buckets of a given volume. Similar to listVolumes, paging supported via
> prevKey, prefix and maxKeys.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
