[
https://issues.apache.org/jira/browse/HDFS-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245247#comment-16245247
]
Yiqun Lin commented on HDFS-12740:
----------------------------------
Thanks for working on this, [~shashikant]. Just some minor comment:
* Could you update name for {{scmId}} to be consistent? I saw sometimes we use
{{scmId}}, but some other places are {{scmUuid}}.
{code}
*/
- public String getscmUuid() {
+ public String getScmId() {
return getStorageInfo().getProperty(SCM_ID);
}
@Override
protected Properties getNodeProperties() {
- String scmUuid = getscmUuid();
+ String scmUuid = getScmId();
if (scmUuid == null) {
scmUuid = UUID.randomUUID().toString();
}
{code}
* We need a unit test to test the RPC call defined in
{{ScmBlockLocationProtocolClientSideTranslatorPB}} Current test just test the
method {{StorageContainerManager#getScmInfo}}.
> SCM should support a RPC to share the cluster Id with KSM and DataNodes
> -----------------------------------------------------------------------
>
> Key: HDFS-12740
> URL: https://issues.apache.org/jira/browse/HDFS-12740
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12740-HDFS-7240.001.patch
>
>
> When the ozone cluster is first Created, SCM --init command will generate
> cluster Id as well as SCM Id and persist it locally. The same cluster Id and
> the SCM id will be shared with KSM during the KSM initialization and
> Datanodes during datanode registration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
