[
https://issues.apache.org/jira/browse/HDFS-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245489#comment-16245489
]
Nanda kumar commented on HDFS-12740:
------------------------------------
Thanks [~shashikant] for reporting and working on this, overall the patch looks
good to me.
Apart from [~linyiqun] comment some NITPICKs
ScmInfo:Suggestion - can be put into org/apache/hadoop/scm instead of
org/apache/hadoop/scm/continer/common/helpers
ScmBlockLocationProtocolClientSideTranslatorPB:Line 36 & 37 - length greater
than 80 character
ScmBlockLocationProtocolClientSideTranslatorPB#getScmInfo - update javadoc
description
ScmInfo.Builder - javadoc for setClusterId and setScmId is missing
> SCM should support a RPC to share the cluster Id with KSM and DataNodes
> -----------------------------------------------------------------------
>
> Key: HDFS-12740
> URL: https://issues.apache.org/jira/browse/HDFS-12740
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12740-HDFS-7240.001.patch
>
>
> When the ozone cluster is first Created, SCM --init command will generate
> cluster Id as well as SCM Id and persist it locally. The same cluster Id and
> the SCM id will be shared with KSM during the KSM initialization and
> Datanodes during datanode registration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
