[
https://issues.apache.org/jira/browse/HDFS-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259781#comment-16259781
]
Nanda kumar commented on HDFS-12740:
------------------------------------
Thanks [~shashikant] for updating the patch, it looks good to me. Some minor
comments,
{{org.apache.hadoop.scm.container.common.helpers}} is not the right place for
{{ScmInfo}}. We can move {{ScmInfo}} under {{org.apache.hadoop.scm}}
MiniOzoneClassicCluster.java
Line:529 - 533 can be replaced with
{{scmStore.setClusterId(clusterId.orElse(runID.toString()))}}
Line:534 - 538 can be replaced with
{{scmStore.setScmId(scmId.orElse(UUID.randomUUID().toString()))}}
NITs
ScmBlockLocationProtocol.proto
Line: 135, 136, 141 & 142 incorrect indentation
StorageContainerManager.java
Line: 1057 & 1058 {{this}} keyword can be removed
> SCM should support a RPC to share the cluster Id with KSM and DataNodes
> -----------------------------------------------------------------------
>
> Key: HDFS-12740
> URL: https://issues.apache.org/jira/browse/HDFS-12740
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12740-HDFS-7240.001.patch,
> HDFS-12740-HDFS-7240.002.patch, HDFS-12740-HDFS-7240.003.patch,
> HDFS-12740-HDFS-7240.004.patch
>
>
> When the ozone cluster is first Created, SCM --init command will generate
> cluster Id as well as SCM Id and persist it locally. The same cluster Id and
> the SCM id will be shared with KSM during the KSM initialization and
> Datanodes during datanode registration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
