[
https://issues.apache.org/jira/browse/HDFS-12740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247366#comment-16247366
]
Mukul Kumar Singh commented on HDFS-12740:
------------------------------------------
Hi Sashikant, the updated patch looks really good, some really minor comments.
1) Can we generate a separate scm id in MiniOzoneCluster? Just to ensure that
both the cluster and scm id values are different in the run.
2) Retreives is spelled wrong in comments.
3) Also in Test, can we generate, random UUIDs, in place of strings like
"testClusterId" & "testScmId".
4) checkstyle issues
> SCM should support a RPC to share the cluster Id with KSM and DataNodes
> -----------------------------------------------------------------------
>
> Key: HDFS-12740
> URL: https://issues.apache.org/jira/browse/HDFS-12740
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Fix For: HDFS-7240
>
> Attachments: HDFS-12740-HDFS-7240.001.patch,
> HDFS-12740-HDFS-7240.002.patch
>
>
> When the ozone cluster is first Created, SCM --init command will generate
> cluster Id as well as SCM Id and persist it locally. The same cluster Id and
> the SCM id will be shared with KSM during the KSM initialization and
> Datanodes during datanode registration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
