[
https://issues.apache.org/jira/browse/HDFS-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305670#comment-16305670
]
Xiao Chen commented on HDFS-12897:
----------------------------------
Thanks [~GeLiXin] for looking into the issue and providing the patch.
Patch looks good overall. Some comments below:
- The {{FSDirectory.isExactReservedName}} check can happen before the path
resolution, so we don't do unnecessary {{fsd.resolvePath}}.
- There is also {{/.reserved/raw}} under {{/.reserved}}. I think path
resolution handles that but would love a test covering it.
- Trivial, but prefer {{ecDotSnapshotDir}} declaration in the test to happen
lazily, right before it's used (instead of at the beginning).
> Path not found when we get the ec policy for a .snapshot dir
> ------------------------------------------------------------
>
> Key: HDFS-12897
> URL: https://issues.apache.org/jira/browse/HDFS-12897
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding, hdfs, snapshots
> Affects Versions: 3.0.0-alpha1, 3.1.0
> Reporter: Harshakiran Reddy
> Assignee: LiXin Ge
> Attachments: HDFS-12897.001.patch, HDFS-12897.002.patch
>
>
> Scenario:-
> ---------------
> Operation on snapshot dir.
> *EC policy*
> bin> ./hdfs ec -getPolicy -path /dir/
> RS-3-2-1024k
> bin> ./hdfs ec -getPolicy -path /dir/.snapshot/
> {{FileNotFoundException: Path not found: /dir/.snapshot}}
> bin> ./hdfs dfs -ls /dir/.snapshot/
> Found 2 items
> drwxr-xr-x - user group 0 2017-12-05 12:27 /dir/.snapshot/s1
> drwxr-xr-x - user group 0 2017-12-05 12:28 /dir/.snapshot/s2
> *Storagepolicies*
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/.snapshot/
> {{The storage policy of /dir/.snapshot/ is unspecified}}
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/
> The storage policy of /dir/:
> BlockStoragePolicy{COLD:2, storageTypes=[ARCHIVE], creationFallbacks=[],
> replicationFallbacks=[]}
> *Which is the correct behavior ?*
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
