[ 
https://issues.apache.org/jira/browse/HDFS-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311555#comment-16311555
 ] 

Rakesh R commented on HDFS-12897:
---------------------------------

Good catch [~xiaochen].
bq. assertEquals("Got unexpected erasure coding policy", ecPolicy, 
fs.getErasureCodingPolicy(snap2ECDir)); // <-- shouldn't
IIRC, there was no discussion about this behavior. I had referred 
[EncryptionZone unit 
testcase|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java#L1337]
 and followed same test pattern. I could see same behavior in EZ as well, could 
you check it once. 
{code}
    fsWrapper.delete(zone, true);
    fsWrapper.mkdir(zone, FsPermission.getDirDefault(), true);
    final Path snap2 = fs.createSnapshot(zoneParent, "snap2");
    final Path snap2Zone = new Path(snap2, zone.getName());
    assertNull("Expected null ez path",
        dfsAdmin.getEncryptionZoneForPath(snap2Zone));

    // Create the encryption zone again
    dfsAdmin.createEncryptionZone(zone, TEST_KEY2, NO_TRASH);

    // FYI, I've added to check there is no encryption policy set as there was 
no policy in this snapshot. 
    assertNull("Expected null ez path",
        dfsAdmin.getEncryptionZoneForPath(snap2Zone));
{code}

Probably, we could add this behavioral changes to the {{release notes}} as well.



> Path not found when we get the ec policy for a .snapshot dir
> ------------------------------------------------------------
>
>                 Key: HDFS-12897
>                 URL: https://issues.apache.org/jira/browse/HDFS-12897
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: erasure-coding, hdfs, snapshots
>    Affects Versions: 3.0.0-alpha1, 3.1.0
>            Reporter: Harshakiran Reddy
>            Assignee: LiXin Ge
>         Attachments: HDFS-12897.001.patch, HDFS-12897.002.patch, 
> HDFS-12897.003.patch
>
>
> Scenario:-
> ---------------
> Operation on snapshot dir.
> *EC policy*
> bin> ./hdfs ec -getPolicy -path /dir/
> RS-3-2-1024k
> bin> ./hdfs ec -getPolicy -path /dir/.snapshot/
> {{FileNotFoundException: Path not found: /dir/.snapshot}}
> bin> ./hdfs dfs -ls /dir/.snapshot/
> Found 2 items
> drwxr-xr-x   - user group          0 2017-12-05 12:27 /dir/.snapshot/s1
> drwxr-xr-x   - user group          0 2017-12-05 12:28 /dir/.snapshot/s2
> *Storagepolicies*
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/.snapshot/
> {{The storage policy of /dir/.snapshot/ is unspecified}}
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/
> The storage policy of /dir/:
> BlockStoragePolicy{COLD:2, storageTypes=[ARCHIVE], creationFallbacks=[], 
> replicationFallbacks=[]}
> *Which is the correct behavior ?*



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to