[ 
https://issues.apache.org/jira/browse/HDFS-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310725#comment-16310725
 ] 

Xiao Chen commented on HDFS-12897:
----------------------------------

Thanks [~GeLiXin] for the continued investigation into this.

bq. What's the supposed, right behavior?
{{TestErasureCodingPolicyWithSnapshot#testSnapshotsOnErasureCodingDirsParentDir}}
 was added by HDFS-8777. Ping [~rakeshr] [~zhz] [~jingzhao], was this 
intentional or was this a miss? I didn't see any discussions about the behavior 
in that jira.

IMO the existing test is wrong:
{code}
...
fs.setErasureCodingPolicy(ecDir, ecPolicy.getName());
final Path snap1 = fs.createSnapshot(ecDirParent, "snap1");
assertEquals("Got unexpected erasure coding policy", ecPolicy, 
fs.getErasureCodingPolicy(snap1ECDir));
...
fs.delete(ecDir, true);
fs.mkdir(ecDir, FsPermission.getDirDefault());
final Path snap2 = fs.createSnapshot(ecDirParent, "snap2");
assertNull("Expected null erasure coding policy", 
fs.getErasureCodingPolicy(snap2ECDir));
...
fs.setErasureCodingPolicy(ecDir, ecPolicy.getName());
final Path snap3 = fs.createSnapshot(ecDirParent, "snap3");
assertEquals("Got unexpected erasure coding policy", ecPolicy, ezSnap3);
...
assertEquals("Got unexpected erasure coding policy", ecPolicy, 
fs.getErasureCodingPolicy(snap1ECDir));
assertEquals("Got unexpected erasure coding policy", ecPolicy, 
fs.getErasureCodingPolicy(snap2ECDir)); // <-- shouldn't this be null?
{code}

> Path not found when we get the ec policy for a .snapshot dir
> ------------------------------------------------------------
>
>                 Key: HDFS-12897
>                 URL: https://issues.apache.org/jira/browse/HDFS-12897
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: erasure-coding, hdfs, snapshots
>    Affects Versions: 3.0.0-alpha1, 3.1.0
>            Reporter: Harshakiran Reddy
>            Assignee: LiXin Ge
>         Attachments: HDFS-12897.001.patch, HDFS-12897.002.patch, 
> HDFS-12897.003.patch
>
>
> Scenario:-
> ---------------
> Operation on snapshot dir.
> *EC policy*
> bin> ./hdfs ec -getPolicy -path /dir/
> RS-3-2-1024k
> bin> ./hdfs ec -getPolicy -path /dir/.snapshot/
> {{FileNotFoundException: Path not found: /dir/.snapshot}}
> bin> ./hdfs dfs -ls /dir/.snapshot/
> Found 2 items
> drwxr-xr-x   - user group          0 2017-12-05 12:27 /dir/.snapshot/s1
> drwxr-xr-x   - user group          0 2017-12-05 12:28 /dir/.snapshot/s2
> *Storagepolicies*
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/.snapshot/
> {{The storage policy of /dir/.snapshot/ is unspecified}}
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/
> The storage policy of /dir/:
> BlockStoragePolicy{COLD:2, storageTypes=[ARCHIVE], creationFallbacks=[], 
> replicationFallbacks=[]}
> *Which is the correct behavior ?*



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to