[
https://issues.apache.org/jira/browse/HDFS-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340596#comment-16340596
]
Xiao Chen commented on HDFS-12897:
----------------------------------
Thanks [~GeLiXin] for the new rev, and sorry for my delayed review here.
Patch 4 LGTM overall. +1 pending 2 nits:
- TestErasureCodingPolicyWithSnapshot: {{final Path snap1 =
fs.createSnapshot(ecDir, "snap0");}} change snap0 to snap1 to be consistent
with the rest of the test
- TestErasureCodingPolicyWithSnapshot: we can set a test class level {{Rule}},
that way we don't have to set timeout on each test cases.
> Path not found when we get the ec policy for a .snapshot dir
> ------------------------------------------------------------
>
> Key: HDFS-12897
> URL: https://issues.apache.org/jira/browse/HDFS-12897
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding, hdfs, snapshots
> Affects Versions: 3.0.0-alpha1, 3.1.0
> Reporter: Harshakiran Reddy
> Assignee: LiXin Ge
> Priority: Major
> Attachments: HDFS-12897.001.patch, HDFS-12897.002.patch,
> HDFS-12897.003.patch, HDFS-12897.004.patch
>
>
> Scenario:-
> ---------------
> Operation on snapshot dir.
> *EC policy*
> bin> ./hdfs ec -getPolicy -path /dir/
> RS-3-2-1024k
> bin> ./hdfs ec -getPolicy -path /dir/.snapshot/
> {{FileNotFoundException: Path not found: /dir/.snapshot}}
> bin> ./hdfs dfs -ls /dir/.snapshot/
> Found 2 items
> drwxr-xr-x - user group 0 2017-12-05 12:27 /dir/.snapshot/s1
> drwxr-xr-x - user group 0 2017-12-05 12:28 /dir/.snapshot/s2
> *Storagepolicies*
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/.snapshot/
> {{The storage policy of /dir/.snapshot/ is unspecified}}
> bin> ./hdfs storagepolicies -getStoragePolicy -path /dir/
> The storage policy of /dir/:
> BlockStoragePolicy{COLD:2, storageTypes=[ARCHIVE], creationFallbacks=[],
> replicationFallbacks=[]}
> *Which is the correct behavior ?*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
