[
https://issues.apache.org/jira/browse/HDFS-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374875#comment-16374875
]
Ajay Kumar commented on HDFS-13181:
-----------------------------------
[~bharatviswa], thanks for working on this. Some minor suggestions:
# Instead of restricting valid interval in hours, it would be better to give
users flexibility to specify it in any time unit.
#* dfs.disk.balancer.valid.plan.hours to dfs.disk.balancer.valid.plan.interval
#* Use {{Configuration#getTimeDuration}} to get time interval.
# We can simplify the test case a bit using new LambadaTestUtils. Something like
{code}LambdaTestUtils.intercept(RemoteException.class, "DiskBalancerException",
() -> { runCommand(cmdLine, hdfsConf, finalMiniCluster);
});{code}
> DiskBalancer: Add an configuration for valid plan hours
> --------------------------------------------------------
>
> Key: HDFS-13181
> URL: https://issues.apache.org/jira/browse/HDFS-13181
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: diskbalancer
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13181.00.patch
>
>
> Add a configuration for valid plan hours, instead of constant 24 hours in the
> code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
