[
https://issues.apache.org/jira/browse/HDFS-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377755#comment-16377755
]
Arpit Agarwal commented on HDFS-13181:
--------------------------------------
Couple of minor comments:
# The variable and setting name are slightly different (plan valid vs valid
plan). Since in other places you use plan valid, you can just rename the
setting name to {{dfs.disk.balancer.plan.valid.interval}}
{code}
+ public static final String DFS_DISK_BALANCER_PLAN_VALID_INTERVAL =
+ "dfs.disk.balancer.valid.plan.interval";
{code}
# For hdfs-default.xml you can use the following boiler-plate text used by many
other time duration settings. Also mention the default unit is milliseconds.
{code}
Supports multiple time unit suffix (case insensitive), as described
in dfs.heartbeat.interval.
{code}
> DiskBalancer: Add an configuration for valid plan hours
> --------------------------------------------------------
>
> Key: HDFS-13181
> URL: https://issues.apache.org/jira/browse/HDFS-13181
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: diskbalancer
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDFS-13181.00.patch, HDFS-13181.01.patch,
> HDFS-13181.02.patch
>
>
> Add a configuration for valid plan hours, instead of constant 24 hours in the
> code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
