[ 
https://issues.apache.org/jira/browse/HDFS-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377183#comment-16377183
 ] 

Ajay Kumar commented on HDFS-13181:
-----------------------------------

[~bharatviswa], Overall patch LGTM. Few minor suggestions.
# New key in {{DFSConfigKeys}} differs from its string value. I suggest 
renaming it to  {{DFS_DISK_BALANCER_PLAN_VALID_INTERVAL}}
# L261 {{TestDiskBalancerCommand}}, space before stat of comment text.


> DiskBalancer: Add an configuration for valid plan hours 
> --------------------------------------------------------
>
>                 Key: HDFS-13181
>                 URL: https://issues.apache.org/jira/browse/HDFS-13181
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>         Attachments: HDFS-13181.00.patch, HDFS-13181.01.patch
>
>
> Add a configuration for valid plan hours, instead of constant 24 hours in the 
> code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to