[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401205#comment-16401205
]
Plamen Jeliazkov commented on HDFS-12977:
-----------------------------------------
Thanks for the thorough review Konstantin.
I believe I have addressed your points and have attached a new patch
(trunk.006) with all fixes in place.
I took a look at checkstyle and addressed all the ones I could find.
I also believe to have now addressed the whitespace concerns from the previous
Jenkins run.
I also took the liberty of making the unit tests more clear and deliberately
comparing dfs.lastSeenStateId vs namesystem.getLastWrittenTransactionId and
ensuring client was "catching up" in alignment state as intended.
> Add stateId to RPC headers.
> ---------------------------
>
> Key: HDFS-12977
> URL: https://issues.apache.org/jira/browse/HDFS-12977
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ipc, namenode
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS_12977.trunk.001.patch, HDFS_12977.trunk.002.patch,
> HDFS_12977.trunk.003.patch, HDFS_12977.trunk.004.patch,
> HDFS_12977.trunk.005.patch, HDFS_12977.trunk.006.patch
>
>
> stateId is a new field in the RPC headers of NameNode proto calls.
> stateId is the journal transaction Id, which represents LastSeenId for the
> clients and LastWrittenId for NameNodes. See more in [reads from Standby
> design
> doc|https://issues.apache.org/jira/secure/attachment/12902925/ConsistentReadsFromStandbyNode.pdf].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
