[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402197#comment-16402197
]
Plamen Jeliazkov commented on HDFS-12977:
-----------------------------------------
I missed one checkstyle warning and somehow managed to mess up the whitespace
removals. Woops. I've attached a new patch that should address everything.
Only issue now is that it seems this patch will add 4 new checkstyles. Please
let me know if that is acceptable.
These are the 4:
{code:java}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:787:
/** Default: null */: First sentence should end with a period.
[JavadocStyle]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:788:
public Builder setAlignmentContext(AlignmentContext alignmentContext) {:57:
'alignmentContext' hides a field. [HiddenField]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java:428:
public Server(Class<?> protocolClass, Object protocolImpl,:12: More than 7
parameters (found 12). [ParameterNumber]
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java:219:
volatile long lastSeenStateId;:17: Variable 'lastSeenStateId' must be private
and have accessor methods. [VisibilityModifier]
{code}
1) RPC.java:787 -- I believe this to be in line with the other comments in the
Builder of RPC.Server.
2) RPC.java:788 -- This is also in line with and following the pattern set by
the other methods / fields of the Builder.
3) WritableRpcEngine.java:428 -- I don't believe there is anything we can do to
address this and I see similar warnings for the other constructor(s).
4) DFSClient.java:219 -- This is perhaps the only one we could actually address
but it falls in line with `lastLeaseRenewal`. If this is a concern I could also
fix it as part of the client portion of the next JIRA.
> Add stateId to RPC headers.
> ---------------------------
>
> Key: HDFS-12977
> URL: https://issues.apache.org/jira/browse/HDFS-12977
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ipc, namenode
> Reporter: Konstantin Shvachko
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS_12977.trunk.001.patch, HDFS_12977.trunk.002.patch,
> HDFS_12977.trunk.003.patch, HDFS_12977.trunk.004.patch,
> HDFS_12977.trunk.005.patch, HDFS_12977.trunk.006.patch,
> HDFS_12977.trunk.007.patch
>
>
> stateId is a new field in the RPC headers of NameNode proto calls.
> stateId is the journal transaction Id, which represents LastSeenId for the
> clients and LastWrittenId for NameNodes. See more in [reads from Standby
> design
> doc|https://issues.apache.org/jira/secure/attachment/12902925/ConsistentReadsFromStandbyNode.pdf].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
