[ https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508751#comment-16508751 ]
genericqa commented on HDDS-156: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 35s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | || || || || {color:brown} HDDS-48 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m 38s{color} | {color:green} HDDS-48 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s{color} | {color:green} HDDS-48 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} HDDS-48 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s{color} | {color:green} HDDS-48 passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 57s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 54s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s{color} | {color:green} HDDS-48 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 19s{color} | {color:orange} hadoop-hdds: The patch generated 48 new + 10 unchanged - 2 fixed = 58 total (was 12) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 13 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 41s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 46s{color} | {color:red} hadoop-hdds/container-service generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 6s{color} | {color:green} common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 35s{color} | {color:red} container-service in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 27s{color} | {color:red} The patch generated 10 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 66m 27s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-hdds/container-service | | | Redundant nullcheck of clusterID, which is known to be non-null in org.apache.hadoop.ozone.container.common.helpers.DatanodeVersionFile.getClusterID(Properties, File, String) Redundant null check at DatanodeVersionFile.java:is known to be non-null in org.apache.hadoop.ozone.container.common.helpers.DatanodeVersionFile.getClusterID(Properties, File, String) Redundant null check at DatanodeVersionFile.java:[line 133] | | | Redundant nullcheck of props, which is known to be non-null in org.apache.hadoop.ozone.container.common.impl.HddsVolume.readVersionFile() Redundant null check at HddsVolume.java:is known to be non-null in org.apache.hadoop.ozone.container.common.impl.HddsVolume.readVersionFile() Redundant null check at HddsVolume.java:[line 210] | | | Switch statement found in org.apache.hadoop.ozone.container.common.impl.HddsVolume.initialize() where one case falls through to the next case At HddsVolume.java:where one case falls through to the next case At HddsVolume.java:[lines 136-139] | | | Redundant nullcheck of clusterID, which is known to be non-null in org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.getClusterID(Properties, File, String) Redundant null check at HddsVolumeUtil.java:is known to be non-null in org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.getClusterID(Properties, File, String) Redundant null check at HddsVolumeUtil.java:[line 71] | | Failed junit tests | hadoop.ozone.container.common.interfaces.TestVolumeSet | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd | | JIRA Issue | HDDS-156 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12927363/HDDS-156-HDDS-48.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 9c7034a0321f 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12 21:23:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HDDS-48 / 0e437f9 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_171 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/PreCommit-HDDS-Build/283/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html | | checkstyle | https://builds.apache.org/job/PreCommit-HDDS-Build/283/artifact/out/diff-checkstyle-hadoop-hdds.txt | | whitespace | https://builds.apache.org/job/PreCommit-HDDS-Build/283/artifact/out/whitespace-tabs.txt | | findbugs | https://builds.apache.org/job/PreCommit-HDDS-Build/283/artifact/out/new-findbugs-hadoop-hdds_container-service.html | | unit | https://builds.apache.org/job/PreCommit-HDDS-Build/283/artifact/out/patch-unit-hadoop-hdds_container-service.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/283/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDDS-Build/283/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 397 (vs. ulimit of 10000) | | modules | C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds | | Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/283/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Implement HDDSVolume to manage volume state > ------------------------------------------- > > Key: HDDS-156 > URL: https://issues.apache.org/jira/browse/HDDS-156 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Hanisha Koneru > Assignee: Hanisha Koneru > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch > > > This Jira proposes the following: > # Implement HDDSVolume to encompass VolumeInfo along with other HDDS > specific fields. > # Read Version file while instantiating HDDSVolumes. > # Write volume level Version file. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org