[
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508995#comment-16508995
]
Bharat Viswanadham commented on HDDS-156:
-----------------------------------------
Hi [~hanishakoneru]
Thanks for the patch.
Few comments.
# HddsVolume.java Line 101: can we add not nullcheck for volumeRoot. (I don't
think we need this check, but if these classes are used directly, it might be
needed)
# Some of the methods in DatanodeVersionFile.java and HddsVolumeUtil.java
looks same. getClusterID, getDatanodeUUID, getLayOutVersion, getProperty and
getCreationTime. Can we remove in one of the file.
# HddsVolume.java Line 112: If data node paths are configured like this
[TYPE][URI] then we need to pass parsed path from StorageLocation.
# Can we add some test cases for above type of paths (which add type to the
path) to validate HddsVolumes works properly or not?
# Can we add test case for HddsVolume.java which tests end to end HddsVolume?
# TestDatanodeVersionFile Line 96: has some Tab spaces.
# And also address the checkstyle and findbug issues reported by jenkins.
> Implement HDDSVolume to manage volume state
> -------------------------------------------
>
> Key: HDDS-156
> URL: https://issues.apache.org/jira/browse/HDDS-156
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch
>
>
> This Jira proposes the following:
> # Implement HDDSVolume to encompass VolumeInfo along with other HDDS
> specific fields.
> # Read Version file while instantiating HDDSVolumes.
> # Write volume level Version file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
