[ 
https://issues.apache.org/jira/browse/HDDS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510522#comment-16510522
 ] 

genericqa commented on HDDS-156:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m 
22s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
56s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
59s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 46s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
59s{color} | {color:red} hadoop-hdds/common in HDDS-48 has 1 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
21s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 20s{color} | {color:orange} hadoop-hdds: The patch generated 17 new + 10 
unchanged - 2 fixed = 27 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch 7 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 47s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
50s{color} | {color:red} hadoop-hdds/container-service generated 2 new + 0 
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  
9s{color} | {color:green} common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 37s{color} 
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
26s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 48s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
|  |  Redundant nullcheck of clusterID, which is known to be non-null in 
org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.getClusterID(Properties,
 File, String)  Redundant null check at HddsVolumeUtil.java:is known to be 
non-null in 
org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.getClusterID(Properties,
 File, String)  Redundant null check at HddsVolumeUtil.java:[line 70] |
|  |  Redundant nullcheck of props, which is known to be non-null in 
org.apache.hadoop.ozone.container.common.volume.HddsVolume.readVersionFile()  
Redundant null check at HddsVolume.java:is known to be non-null in 
org.apache.hadoop.ozone.container.common.volume.HddsVolume.readVersionFile()  
Redundant null check at HddsVolume.java:[line 234] |
| Failed junit tests | 
hadoop.ozone.container.common.helpers.TestDatanodeVersionFile |
|   | hadoop.ozone.container.common.volume.TestRoundRobinVolumeChoosingPolicy |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-156 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12927559/HDDS-156-HDDS-48.003.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 76692c3718e5 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / 7e228e5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/artifact/out/branch-findbugs-hadoop-hdds_common-warnings.html
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/artifact/out/diff-checkstyle-hadoop-hdds.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/artifact/out/whitespace-tabs.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/artifact/out/new-findbugs-hadoop-hdds_container-service.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/artifact/out/patch-unit-hadoop-hdds_container-service.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 303 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/295/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Implement HDDSVolume to manage volume state
> -------------------------------------------
>
>                 Key: HDDS-156
>                 URL: https://issues.apache.org/jira/browse/HDDS-156
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, 
> HDDS-156-HDDS-48.003.patch
>
>
> This Jira proposes the following:
>  # Implement HDDSVolume to encompass VolumeInfo along with other HDDS 
> specific fields.
>  # Read Version file while instantiating HDDSVolumes.
>  # Write volume level Version file.
>  
> [Edit]: Adding below information, which might be useful to add in to the Jira 
> description.
>  1. DN is restarted (volumes already exist). In this case, the clusterId is 
> inferred from version file
>  New setup, in this case, we do not know the clusterID till we contact the 
> SCM. So the volumes will be in NOT_FORMATTED state and the version file will 
> not be written.
>  
> In case 2, once we get the clusterID from SCM, we need to format the volumes. 
> This is not done in the current patch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to