Anu Engineer commented on HDDS-156:

+1, Please go ahead and commit this when you get a chance.

One minor comment, It would be good to file a JIRA for this future feature.
private final String storageId;
private final String clusterId;
private final String datanodeUuid;
Storage ID - identifies the storage.
cluster ID - identifies the cluster.
datanode UUID - identifies the data node.

We might want to add 1 more identifiers.
 # ScmGroupID - it identifies the set of SCMs that this datanode talks to, or 
takes commands from if you want we can call this SCM ID.

This value is not same as Cluster ID – since a cluster can technically have 
more than one SCM group.

> Implement HDDSVolume to manage volume state
> -------------------------------------------
>                 Key: HDDS-156
>                 URL: https://issues.apache.org/jira/browse/HDDS-156
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>             Fix For: 0.2.1
>         Attachments: HDDS-156-HDDS-48.001.patch, HDDS-156-HDDS-48.002.patch, 
> HDDS-156-HDDS-48.003.patch, HDDS-156-HDDS-48.004.patch, 
> HDDS-156-HDDS-48.005.patch
> This Jira proposes the following:
>  # Implement HDDSVolume to encompass VolumeInfo along with other HDDS 
> specific fields.
>  ** VolumeInfo container disk specific information such as capacity, usage, 
> storageType. HddsVolume has hdds specific fields for volume such as 
> VolumeState, VolumeStats (will be added later).
>  # Write volume level Version file 
>  ** clusterID, storageID, datanodeUUID, creationTime and layoutVersion.
>  # Read Version file while instantiating HDDSVolumes.
>  ** When the volume Version file already exists (for example, when a DN is 
> restarted), then the version file is read for the stored clusterID, 
> datanodeUuid, lahyoutVersion etc. Some checks will be performed to verify the 
> sanity of the volume.
>  ** When a fresh Datanode is started, the Version file is not written to the 
> volume uptill the clusterID is received from the SCM.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to