[
https://issues.apache.org/jira/browse/HDDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716360#comment-16716360
]
Xiaoyu Yao commented on HDDS-805:
---------------------------------
Thanks [~ajayydv] for the update. A few more comments:
ChunkgroupInputStream.java
Line 302: what's the block token service field here? If we are using the same
token service field, only one token might be added to UGI.
Found it in OzoneBLockTokenSecretmanager#generateToken(), seems we are using
blockID as the token service field. Can we add more comments on this. Do we
need a different token selector to select the appropriate token when using the
UGI with multiple block tokens?
ContainerOperationClient.java
Line 118: please add TODO or followup JIRAs to add DN tokens for these
operations.
KeyManagerImpl.java
Line 216: do we assume HadoopRPC always have remote user setup already here?
If not, I don't think we should use the OM current user context as remote user.
XCeiverClientManager.java
Line 152/160: if we move the client.connect() for RATIS only, do we miss a
connect for STAND_ALONE?
> Block token: Client api changes for block token
> -----------------------------------------------
>
> Key: HDDS-805
> URL: https://issues.apache.org/jira/browse/HDDS-805
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Security
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-805-HDDS-4.00.patch, HDDS-805-HDDS-4.01.patch,
> HDDS-805-HDDS-4.02.patch, HDDS-805-HDDS-4.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]