[
https://issues.apache.org/jira/browse/HDFS-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808003#comment-16808003
]
Íñigo Goiri commented on HDFS-13853:
------------------------------------
Thanks [~ayushtkn] for the update, minor comments:
* Fix the checkstyle warnings.
* The warning in RouterAdmin#300 could be done without the + operator by moving
all to the second line.
* Add space between the comment and the text (RouterAdmin#588).
* Remove the empty line in RouterAdmin#686.
* Instead of {{true/false}}, do {{true|false}}.
* I would leave {{testUpdateNonExistingMountTable}} with an update for the new
behavior (already covered, but better to have smaller tests).
* Actually, it may make sense to split {{testUpdateChangeAttributes()}} a
little more.
> RBF: RouterAdmin update cmd is overwriting the entry not updating the existing
> ------------------------------------------------------------------------------
>
> Key: HDFS-13853
> URL: https://issues.apache.org/jira/browse/HDFS-13853
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Dibyendu Karmakar
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-13853-HDFS-13891-01.patch,
> HDFS-13853-HDFS-13891-02.patch, HDFS-13853-HDFS-13891-03.patch,
> HDFS-13853-HDFS-13891-04.patch
>
>
> {code:java}
> // Create a new entry
> Map<String, String> destMap = new LinkedHashMap<>();
> for (String ns : nss) {
> destMap.put(ns, dest);
> }
> MountTable newEntry = MountTable.newInstance(mount, destMap);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
