[
https://issues.apache.org/jira/browse/HDFS-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808934#comment-16808934
]
Íñigo Goiri commented on HDFS-13853:
------------------------------------
I have more comments...
* When we catch an exception when parsing the parameters (line 640), we should
set the cause and probably add the message.
* After doing the previous one, we probably can just throw the exception for
the DestinationOrder parsing in line 617.
* Can we extract the intermediate variables in the block 607-633? Easier to get
the exception line.
* Usually is better to have the equals for the strings in the other way (e.g.,
line 608 {{"-readonly".equals(parameters[i])}}) as you make sure the first one
is not null (not the case here but good to have). Actually, does it make sense
to have a switch/case here?
* Check for error message in {{testUpdateNonExistingMountTable()}}.
* Add a couple more errors to specially check for a couple more {{Unable to
parse arguments}} exceptions as we are updating them to have more details.
> RBF: RouterAdmin update cmd is overwriting the entry not updating the existing
> ------------------------------------------------------------------------------
>
> Key: HDFS-13853
> URL: https://issues.apache.org/jira/browse/HDFS-13853
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Dibyendu Karmakar
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-13853-HDFS-13891-01.patch,
> HDFS-13853-HDFS-13891-02.patch, HDFS-13853-HDFS-13891-03.patch,
> HDFS-13853-HDFS-13891-04.patch, HDFS-13853-HDFS-13891-05.patch
>
>
> {code:java}
> // Create a new entry
> Map<String, String> destMap = new LinkedHashMap<>();
> for (String ns : nss) {
> destMap.put(ns, dest);
> }
> MountTable newEntry = MountTable.newInstance(mount, destMap);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
