[
https://issues.apache.org/jira/browse/HDFS-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809314#comment-16809314
]
Íñigo Goiri commented on HDFS-13853:
------------------------------------
Thanks [~ayushtkn], minor comments:
* Fix the check styles.
* I'm guessing the exception for {{DestinationOrder#valueOf()}} is a runtime
one? Otherwise, we could just let the exception pass.
* There is also {{Boolean#parseBoolean()}}; any advantage using that?
* Remove the extra space before the collon inRouterAdmin #676
> RBF: RouterAdmin update cmd is overwriting the entry not updating the existing
> ------------------------------------------------------------------------------
>
> Key: HDFS-13853
> URL: https://issues.apache.org/jira/browse/HDFS-13853
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Dibyendu Karmakar
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-13853-HDFS-13891-01.patch,
> HDFS-13853-HDFS-13891-02.patch, HDFS-13853-HDFS-13891-03.patch,
> HDFS-13853-HDFS-13891-04.patch, HDFS-13853-HDFS-13891-05.patch,
> HDFS-13853-HDFS-13891-06.patch
>
>
> {code:java}
> // Create a new entry
> Map<String, String> destMap = new LinkedHashMap<>();
> for (String ns : nss) {
> destMap.put(ns, dest);
> }
> MountTable newEntry = MountTable.newInstance(mount, destMap);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
