[
https://issues.apache.org/jira/browse/HDFS-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809402#comment-16809402
]
Ayush Saxena commented on HDFS-13853:
-------------------------------------
{quote}There is also {{Boolean#parseBoolean()}}; any advantage using that?
{quote}
I used that only in the previous versions, but as you said we should have
proper exception in the case of non true false. This method didn't do so, It
just checks for true, if the value is true it returns true else it returns
false.
{quote}I'm guessing the exception for {{DestinationOrder#valueOf()}} is a
runtime one? Otherwise, we could just let the exception pass.
{quote}
That seems runtime only. But the exception message isn't that good.
update: No enum constant
org.apache.hadoop.hdfs.server.federation.resolver.order.DestinationOrder.Invalid
Anyhow to polish the exception we need to handle it somewhere, so I guess this
should be OK
> RBF: RouterAdmin update cmd is overwriting the entry not updating the existing
> ------------------------------------------------------------------------------
>
> Key: HDFS-13853
> URL: https://issues.apache.org/jira/browse/HDFS-13853
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Dibyendu Karmakar
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-13853-HDFS-13891-01.patch,
> HDFS-13853-HDFS-13891-02.patch, HDFS-13853-HDFS-13891-03.patch,
> HDFS-13853-HDFS-13891-04.patch, HDFS-13853-HDFS-13891-05.patch,
> HDFS-13853-HDFS-13891-06.patch, HDFS-13853-HDFS-13891-07.patch
>
>
> {code:java}
> // Create a new entry
> Map<String, String> destMap = new LinkedHashMap<>();
> for (String ns : nss) {
> destMap.put(ns, dest);
> }
> MountTable newEntry = MountTable.newInstance(mount, destMap);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
