[
https://issues.apache.org/jira/browse/HDFS-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199277#comment-13199277
]
Aaron T. Myers commented on HDFS-2863:
--------------------------------------
The patch largely looks good, Bikas. A few comments:
# I think "{{editsDirs.clear(); editsDirs.addAll(uniqueEditsDirs);}}" can just
be replaced with "{{editsDirs = uniqueEditsDirs}}", right?
# Instead of saying "duplicate entries in edits/shared.edits dirs" in the error
message, how about something more helpful to the user, like '"overlapping
entries in " + DFSConfigKeys.DFS_NAMENODE_EDITS_DIR_KEY + " and " +
DFSConfigKeys.DFS_NAMENODE_SHARED_EDITS_DIR_KEY' ?
# Rather than listing the number of entries that will be used, how about
listing the actual entries using Joiner?
bq. Any existing tests I could change?
None that I know of, so please add one or two.
> Failures observed if dfs.edits.dir and shared.edits.dir have same directories.
> ------------------------------------------------------------------------------
>
> Key: HDFS-2863
> URL: https://issues.apache.org/jira/browse/HDFS-2863
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Jitendra Nath Pandey
> Assignee: Bikas Saha
> Attachments: HDFS-2863.HDFS-1623.patch
>
>
> If same edits directory is configured in twice, both are treated
> independently. Edit log roll is called on the same directory twice causing
> exceptions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
