[ 
https://issues.apache.org/jira/browse/HDFS-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199326#comment-13199326
 ] 

Aaron T. Myers commented on HDFS-2863:
--------------------------------------

bq. I did not assign editDirs = uniqueEditDirs because I did not want the Set 
semantics to leak into the Collection return type of that method. These are 
small lists anyways and so I wasnt bothered about the perf.

Seems perhaps a little overly-cautious, as nobody should be mutating the 
results of what's returned from these methods, but I agree it can't hurt 
anything the way you have it. :)

bq. I will look at the other suggestions starting with finding out what a 
Joiner is 

http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Joiner.html

Just something for concatenating collections with a separator, e.g. 
'Joiner.on(",").join(<collection>)'
                
> Failures observed if dfs.edits.dir and shared.edits.dir have same directories.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-2863
>                 URL: https://issues.apache.org/jira/browse/HDFS-2863
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Jitendra Nath Pandey
>            Assignee: Bikas Saha
>         Attachments: HDFS-2863.HDFS-1623.patch
>
>
> If same edits directory is configured in twice, both are treated 
> independently. Edit log roll is called on the same directory twice causing 
> exceptions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to