[ 
https://issues.apache.org/jira/browse/HDFS-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199370#comment-13199370
 ] 

Bikas Saha commented on HDFS-2863:
----------------------------------

1.Will do
2.I added the TestFSNamesystem to be a class for adding future unit tests for 
the same source class. The test is not really HA specific since the dups can 
occur in the edits.dirs config itself right?
3.The unit test tests what the function does. So IMO it makes sense the way its 
written currently. The fact that we currently support a single shared edits dir 
is not related to the test and should be ideally covered in a functional sanity 
test for the HA config feature right?

Will update the patch shortly.
                
> Failures observed if dfs.edits.dir and shared.edits.dir have same directories.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-2863
>                 URL: https://issues.apache.org/jira/browse/HDFS-2863
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Jitendra Nath Pandey
>            Assignee: Bikas Saha
>         Attachments: HDFS-2863.HDFS-1623.patch, HDFS-2863.HDFS-1623.patch
>
>
> If same edits directory is configured in twice, both are treated 
> independently. Edit log roll is called on the same directory twice causing 
> exceptions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to