[ 
https://issues.apache.org/jira/browse/HDFS-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199365#comment-13199365
 ] 

Aaron T. Myers commented on HDFS-2863:
--------------------------------------

Thanks for adding the test. A few small comments:

# No need for the "joiner" variable - it's only used once.
# I think "TestFSNamesystem" isn't a very good name for this test, since this 
really only tests a very specific part of HA configuration. Perhaps just add 
this test case to TestHAConfiguration?
# Since we currently only support a single shared edits dir, the test could be 
made more realistic by not configuring several.
                
> Failures observed if dfs.edits.dir and shared.edits.dir have same directories.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-2863
>                 URL: https://issues.apache.org/jira/browse/HDFS-2863
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Jitendra Nath Pandey
>            Assignee: Bikas Saha
>         Attachments: HDFS-2863.HDFS-1623.patch, HDFS-2863.HDFS-1623.patch
>
>
> If same edits directory is configured in twice, both are treated 
> independently. Edit log roll is called on the same directory twice causing 
> exceptions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to