[
https://issues.apache.org/jira/browse/HDFS-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204912#comment-13204912
]
Aaron T. Myers commented on HDFS-2914:
--------------------------------------
Hey Hari, a few comments:
# Is the "while (nn1.getNamesystem().isInSafeMode())" actually necessary? I
would think this would be covered by the "cluster.waitActive()" call above. If
not, then that's a bug in the minicluster that should be fixed.
# It doesn't seem like this test would necessarily reliably fail without the
fix, given that the NNResourceChecker thread runs asynchronously and only every
few seconds.
# Rather than doing "assertEquals(false, ...)" just do "assertFalse(...)".
> HA: Standby should not enter safemode when resources are low
> ------------------------------------------------------------
>
> Key: HDFS-2914
> URL: https://issues.apache.org/jira/browse/HDFS-2914
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Hari Mankude
> Assignee: Hari Mankude
> Attachments: HDFS-2914-HDFS-1623, hdfs-2914
>
>
> When shared edits dir is bounced, standby NN is put into safemode by the
> NameNodeResourceMonitor(). However, there is no path for it to exit out of
> safe mode when shared edits dir reappears.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira