[
https://issues.apache.org/jira/browse/HDFS-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205604#comment-13205604
]
Aaron T. Myers commented on HDFS-2914:
--------------------------------------
Hey Hari, a few more comments:
# The patch file still needs to have the ".patch" extension.
# Rather than sleep for 10 seconds, let's increase the frequency which the
NNResourceChecker threads runs to every 0 or 1 seconds, and then sleep for 2
seconds.
# Our coding conventions require the use of curly braces ("{}") even for
single-line if statements.
# What do you think the behavior should be for an NN which is active,
experiences low resources, then becomes standby? I *think* the current behavior
seems fine (i.e. require the admin to make the now-standby NN leave SM) but I'm
wondering if you've considered this case. You might want to write a test case
which asserts the desired behavior.
# Note that Jitendra's suggestion also said "When it transitions to active,
that's when a check for available resources to write logs should be performed."
I agree with this (much as the NN currently checks for available resources on
startup) but your patch doesn't implement this.
> HA: Standby should not enter safemode when resources are low
> ------------------------------------------------------------
>
> Key: HDFS-2914
> URL: https://issues.apache.org/jira/browse/HDFS-2914
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Hari Mankude
> Assignee: Hari Mankude
> Attachments: HDFS-2914-HDFS-1623, HDFS-2914-HDFS-1623, hdfs-2914
>
>
> When shared edits dir is bounced, standby NN is put into safemode by the
> NameNodeResourceMonitor(). However, there is no path for it to exit out of
> safe mode when shared edits dir reappears.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
