[
https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146548#comment-14146548
]
Colin Patrick McCabe commented on HDFS-7011:
--------------------------------------------
bq. As discussed before, libhdfs3 is not a good name and should be changed.
libhdfs only provide C interface and do not have namespace issue.
OK. I can put it in "namespace hdfs" for now. Please, let's put off the
library name discussion until later or else we'll never finish :)
bq. I think it is necessary to keep the copyright history since not like other
code in HDFS, libhdfs3 was proprietary software before open source.
Apache's policy is very clear here. See
http://www.apache.org/legal/src-headers.html, the section labelled "Source File
Headers for Code Developed at the ASF"
bq. If the source file is submitted with a copyright notice included in it, the
copyright owner (or owner's agent) must either: remove such notices, or move
them to the NOTICE file associated with each applicable project release, or
provide written permission for the ASF to make such removal or relocation of
the notices. Each source file should include the following license header --
note that there should be no copyright notice in the header: \[apache 2.0
license header\]
We also don't permit author tags (Jenkins specifically checks for and -1s any
patches that contain them).
bq. I block many signals in backend worker thread, these signals should only be
handled in main thread. libhdfs3 will not raise SIGPIPE at all.
I agree that SIGPIPE should not be raised if the proper precautions are taken
during send, write, etc. But since we know we don't ever want SIGPIPE, why not
block it?
Is the reason you want to block the other signals in the worker thread that
this will allow an application that wants to handle them specifically will be
able to do so? That makes sense, and I will add back the other signal blocking.
> Implement basic utilities for libhdfs3
> --------------------------------------
>
> Key: HDFS-7011
> URL: https://issues.apache.org/jira/browse/HDFS-7011
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Zhanwei Wang
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7011-pnative.001.patch, HDFS-7011.patch
>
>
> Implement basic utilities such as hash, exception handling, logger, configure
> parser, checksum calculate and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
