[
https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149948#comment-14149948
]
Colin Patrick McCabe commented on HDFS-7011:
--------------------------------------------
bq. My suggestion is to introduce std::tr1::shared_ptr into namespace
hdfs::internal in file Memory.h and other files include Memory.h and use
hdfs::internal::shared_ptr, so that we do not need to change all other place
where it is used.
This creates more confusion for people reading the code, though. They have to
hunt down the header file to find out that what we're using is
{{std::tr1::shared_ptr}}. I think it's better just to use the standard library
type directly since it should always be available, and familiar to all C++
programmers.
bq. I do not block SIGPIPE in worker thread because it is never be raised in
libhdfs3, and it is per-thread (it is sent to the thread doing the write system
call) signal. Only per-process (it is sent to a process as a whole, any thread
that doesn't block it can be chosen to handle it) signals should be blocked in
worker thread.
I don't see any reason why we shouldn't block it. If, as you say, it's never
raised, then the blocking has no effect. If it is accidentally raised
somewhere, then the blocking is useful. So either way, blocking is better than
not blocking.
> Implement basic utilities for libhdfs3
> --------------------------------------
>
> Key: HDFS-7011
> URL: https://issues.apache.org/jira/browse/HDFS-7011
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Zhanwei Wang
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7011-pnative.001.patch,
> HDFS-7011-pnative.002.patch, HDFS-7011.patch
>
>
> Implement basic utilities such as hash, exception handling, logger, configure
> parser, checksum calculate and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
