[
https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150420#comment-14150420
]
Zhanwei Wang commented on HDFS-7011:
------------------------------------
I did not see any confusion about "shared_ptr", its name already tell
everything. std::tr1::shared_ptr is not C++ standard, but std::shared_ptr is.
So std::shared_ptr should be always available but std::tr1::shared_ptr not. GCC
does not guarantee not to drop "tr1" namespace(probably never happen).
So if you use "std::shared_ptr", it is ok to me to use it directly. If you use
"std::tr1::shared_ptr", I suggest to introduce it into namespace
hdfs::internal. After all TR1 was not a standard itself, we should only use the
standard C++ library directly.
If SIGPIPE is accidentally raised somewhere in libhdfs3, it is a bug. Instead
of cover the bug, I'd like to expose it fast.
Otherwise blocking SIGPIPE has no effect but introduce confusion (why we block
it even if we do know it does nothing). So either way, not blocking is better
than blocking.
> Implement basic utilities for libhdfs3
> --------------------------------------
>
> Key: HDFS-7011
> URL: https://issues.apache.org/jira/browse/HDFS-7011
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Zhanwei Wang
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7011-pnative.001.patch,
> HDFS-7011-pnative.002.patch, HDFS-7011.patch
>
>
> Implement basic utilities such as hash, exception handling, logger, configure
> parser, checksum calculate and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
