[ 
https://issues.apache.org/jira/browse/HDFS-7011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153773#comment-14153773
 ] 

Colin Patrick McCabe commented on HDFS-7011:
--------------------------------------------

bq. Blocking SIGPIPE in backend worker thread is not important since it does 
nothing, I agree to discuss it later.

Thank you.

bq. But I have to say use "std::tr1" namespace directly is... inappropriate for 
the following reasons:  At this time, shared_ptr is already in C++ standard and 
"std::tr1" namespace is NOT in C++ standard

tr1 is a really old and well-supported thing.  {{unordered_map}} and 
{{shared_ptr}} are both part of tr1, and I was using them around 10 years ago 
to write C++ code.  It's a little weird to hear people refer to them as "C++11 
features" since they already existed in tr1 a long time ago.

Still, it seems that you are right that tr1 is not technically "part of the 
standard."  Or rather, it's part of "a" standard, but not the C++11 standard.  
So I will introduce {{std::tr1::shared_ptr}} into the hdfs namespace as you 
suggested, and we can do the same for any other tr1 things we add later.

> Implement basic utilities for libhdfs3
> --------------------------------------
>
>                 Key: HDFS-7011
>                 URL: https://issues.apache.org/jira/browse/HDFS-7011
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7011-pnative.001.patch, 
> HDFS-7011-pnative.002.patch, HDFS-7011.patch
>
>
> Implement basic utilities such as hash, exception handling, logger, configure 
> parser, checksum calculate and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to