Hello Sean, thanks for the patches. Dne 2. dubna 2012 8:51 Sean Bartell <[email protected]> napsal(a): > Hello all, > > I've already made a few small improvements to HelenOS. > lp:~wtachi/helenos/sleep implements bdsh/sleep and I have looked at the patch and I have a few small comments. * There is missing indentation in help_cmd_sleep() for the second printf but this is really minor issue. * Why is str_useconds_t declared static yet it is in the header file? The purpose of static functions is to create functions private for single source file. * And I do not like the str_useconds_t name much. IMHO the name shall reflect that it parses input expressed in seconds (with fractions) but returns usecs.
Unless you want to correct the problems yourself, I will do it and merge it (probably later this week). > lp:~wtachi/helenos/python3 makes a few scripts work with Python 3 as Cool. It works for me. Now the only profile that could not be built with Python 3 is arm32/gta02. But before merging this, I would like to hear from other people running Python2-only to confirm that it didn't broke anything for them. Again, thanks for your contribution. - Vojta > well as Python 2. I intend to make another improvement or two by Friday. > > There's one question I'd like to ask about your approach to GSoC. How do > you most frequently communicate with students? I checked the mailing > list archives for 2011 and I see only occasional student updates. > > Thanks, > Sean Bartell > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/cgi-bin/listinfo/helenos-devel _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
