Hello, On Mon, Apr 02, 2012, Vojtech Horky wrote: > Dne 2. dubna 2012 8:51 Sean Bartell <wingedtachikoma at gmail.com napsal(a): > > I've already made a few small improvements to HelenOS. > > lp:~wtachi/helenos/sleep implements bdsh/sleep and > I have looked at the patch and I have a few small comments. > * There is missing indentation in help_cmd_sleep() for the second > printf but this is really minor issue.
Noted and fixed. > * Why is str_useconds_t declared static yet it is in the header file? > The purpose of static functions is to create functions private for > single source file. I imitated some of the other commands, like cat/cat.h. If they're wrong, I can fix them. > * And I do not like the str_useconds_t name much. IMHO the name shall > reflect that it parses input expressed in seconds (with fractions) but > returns usecs. I tried to make it consistent with str_uint<n>_t, but I could rename it to decimal_to_useconds. Thanks, Sean Bartell _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
